-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative mitogenome strategy needed when MitoHifi fails. #86
Comments
I would prefer this is added to the run |
|
Then let's create a strategy to deal with it. So what exactly is the cause of failure? Is it MitoHifi exiting with an error (non-zero exit code?), or does Nextflow exit with an error because of certain files not being present (we can make a PR to change the module on nf-core modules, or make a local module with that behaviour - Then if an output is empty it could trigger a different process)? It seems we should add a section to do assembly from reads. Should we make this the default, rather than from contigs? Should this be a complementary assembly strategy like the hifiasm assembly (e.g. so one can just assemble the organelles ( or choose mitochondria/chloroplast specifically)? |
Exit status 1, failed
|
There's oneish alternative strategy in the notes you listed. |
Yes. I pulled mtdna reads using minimap2 and a reference, then de-novo assembled using MBG. I'm not sure it is worth it to implement this in a module right now because multiple k-mer and window sizes need to be tested in until you get a single circular contig. Not sure a set of default parameters would transfer well between datasets, but it could be the target of some development from us. Haven't tried oatk yet. |
Will leave issue open as a reminder to implement alternative mitogenome strategy. Related paper: MBG https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8521641/ |
Note: Update directive value to |
Is your feature request related to a problem? Please describe.
In my experience MitoHiFi has often not worked and I need to employ another strategy to assemble the mtdna (plus additional organelles).
Describe the solution you'd like
I suggest that a failure in the mitohifi process is ignored and the remaining workflow proceeds normally. Like:
errorStrategy 'ignore'
The text was updated successfully, but these errors were encountered: