Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new file #113

Closed
wants to merge 3 commits into from
Closed

Conversation

mnlevy1981
Copy link
Collaborator

@mnlevy1981 mnlevy1981 commented Jul 10, 2024

Just trying to test the new github PR template location (and also see if the checklist action is being run)

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Just trying to test the new github PR template location (and also see if the
checklist action is being run)
@mnlevy1981
Copy link
Collaborator Author

It looks like the PR template works :)

New PR

Also seeing a failure for PR Tasks Completed Check, will start checking boxes and see if that'll eventually pass

@mnlevy1981
Copy link
Collaborator Author

The checklist task is failing because

Run kentaro-m/[email protected]
  with:
    repo-token: ***
Error: Resource not accessible by integration

Give "write" permission to "checks"
Comment on lines 9 to 10
permissions:
checks: write
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think updating a workflow yml file in a PR will run the version of the test from main -- I'm still seeing

GITHUB_TOKEN Permissions
  Checks: read
  Metadata: read

When checks should be "write". I'm tempted to make this change directly on main and re-run the test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@mnlevy1981
Copy link
Collaborator Author

Closing this, will try to start a new PR from updated main with current permissions

@mnlevy1981 mnlevy1981 closed this Jul 10, 2024
@mnlevy1981 mnlevy1981 deleted the test_pr_template branch July 10, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants