-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for Issue #89: "Ensure CUPiD is generalizable and portable to other machines" #92
base: main
Are you sure you want to change the base?
Conversation
Hi @shivaniikum , thanks for getting this PR started, and nice work finding all of these One main thing that I'm noticing is that we want to generalize how we read in files while also maintaining the functionality of pointing to the current paths. So, I think it would be useful to set a root directory in a @mnlevy1981 do you want to add anything else to this suggestion? |
Nothing to add to your specific suggestion, but I also wanted to ask @shivaniikum to merge the latest |
Actually, one thing to add - we're okay with modifying the directory structure under |
Thank you for reviewing this PR @mnlevy1981 and @TeaganKing. I will work on making these changes. |
Two more requests before digging in for an actual review:
|
This pull request addresses issue #89 and contains changes to the config_f.cam6_3_119.FLTHIST_ne30.r328_gamma0.33_soae.001.yaml file at path "examples/nblibrary/config_f.cam6_3_119.FLTHIST_ne30.r328_gamma0.33_soae.001.yaml".
I've removed hardcoded references to glade/ and added global variables to the top of the file and changed to relative file paths throughout the rest of the file. (Note: users should change the start and end year variables to match their cesm output files).