Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement timestep_init phases and catch up with master of ccpp-physics (2021/03/04) #239

Merged
merged 7 commits into from
Mar 4, 2021

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Mar 4, 2021

Replaces #223

  • Implement the timestep_init/finalize phases in SCM source code
  • update to ccpp-physics master as of 2021/03/04
  • change build system so that ccpp_prebuild.py writes caps/cmake snippets to build directory rather than src directory (this now works with the default CMakeLists.txt in ccpp-physics)
  • change the diagnostic bucket clearing to SCM code
    -- change timing of diagnostic clearing (order of operations was wrong)
    -- allow for diagnostic clearing every timestep
  • comment out reading in RUC LSM init variables since changes to ccpp-physics has rendered it obsolete (followup PR needed to read in RUC LSM init data)

@grantfirl
Copy link
Collaborator Author

Will likely need followup PR to accommodate recent changes in LSM initializations. The existing canned cases have been tested to work with this PR.

@grantfirl
Copy link
Collaborator Author

There are many whitespace changes in GFS_typedefs.F90/meta. This is on purpose to match changes in the FV3 versions of these files.

@grantfirl
Copy link
Collaborator Author

Associated with NCAR/ccpp-physics#562, which has already been merged.

@grantfirl
Copy link
Collaborator Author

@dustinswales This catches the SCM up with ccpp-physics master, including recently merged RRTMGP changes.

@grantfirl grantfirl merged commit f2f4217 into NCAR:master Mar 4, 2021
dustinswales pushed a commit to dustinswales/ccpp-scm that referenced this pull request May 16, 2022
implement timestep_init phases and catch up with master of ccpp-physics (2021/03/04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants