ufs/dev PR#228 #557
Merged
ufs/dev PR#228 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hertneky
requested review from
dustinswales,
grantfirl,
mkavulich and
scrasmussen
as code owners
|
@hertneky FYI, once the ccpp-physics is merged (which I just did), the upstream PR for SCM needs to update its submodule pointer to point to the latest NCAR/main branch of ccpp-physics. This is accomplished by making sure that your PR branch of ccpp-scm is checked out, cd into ccpp/physics, I just did this to your PR branch to save time. We're ready to approve/merge this now. |
grantfirl
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to typedefs
Additional changes made to ccpp-physics GFS_debug.F90 to remove deleted variables that were causing initial build failure.