Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coriolis_param #176

Merged
merged 15 commits into from
Feb 4, 2025
Merged

coriolis_param #176

merged 15 commits into from
Feb 4, 2025

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Jan 28, 2025 •
edited
Loading

PR Summary

Covers coriolis_param to calculate the Coriolis parameter for a given latitude as part of Meteorology functionality not covered by geocat-comp

Related Tickets & Documents

Closes #175

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist
  • If adding a new page, select which type:
    • NCL Entry
    • Receipt
  • Clear Outputs

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

Meowdy! See your PR preview:
🔍 Git commit SHA: d8ccabd
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/176

@cyschneck cyschneck self-assigned this Jan 28, 2025
@cyschneck cyschneck added ncl receipt Receipt files are small files with little to no narrative content ncl entry NCL entries are pages that explain specifically how to achieve something that was possible in NCL labels Jan 28, 2025
@cyschneck cyschneck marked this pull request as ready for review January 30, 2025 20:50
kafitzgerald
kafitzgerald approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a minor typo, but otherwise looks good!

ncl/receipts/meteorology.ipynb Outdated Show resolved Hide resolved
@cyschneck @kafitzgerald
Update ncl/receipts/meteorology.ipynb
52d41ef 
Co-authored-by: Katelyn FitzGerald <[email protected]>
@cyschneck cyschneck requested a review from jukent February 3, 2025 22:46
anissa111
anissa111 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cyschneck cyschneck merged commit 3008321 into NCAR:main Feb 4, 2025
3 checks passed
@cyschneck cyschneck deleted the coriolis_para branch February 4, 2025 18:06
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
@cyschneck @github-actions
Delete preview for pull request #176
5b9664a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kafitzgerald kafitzgerald kafitzgerald approved these changes

@anissa111 anissa111 anissa111 approved these changes

@jukent jukent Awaiting requested review from jukent

Assignees

@cyschneck cyschneck

Labels
ncl entry NCL entries are pages that explain specifically how to achieve something that was possible in NCL ncl receipt Receipt files are small files with little to no narrative content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meterology - coriolis_param
4 participants
@cyschneck @kafitzgerald @anissa111 @jukent