Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action test #174

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Action test #174

merged 5 commits into from
Jul 9, 2024

Conversation

K20shores
Copy link
Collaborator

  • Uses os.path.join to create os-independent paths
  • Replaced all command line argument paths with forward slashes
  • Removed redundant requirements.txt file (apparently the new fad is to put everything into pyproject.toml so requirements.txt is no longer necessary)

@K20shores K20shores requested a review from carl-drews July 5, 2024 14:06
Copy link
Collaborator

@carl-drews carl-drews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@carl-drews carl-drews merged commit 3e0072a into carls-main01 Jul 9, 2024
3 of 6 checks passed
@carl-drews carl-drews deleted the action_test branch July 9, 2024 23:15
mattldawson added a commit that referenced this pull request Jul 16, 2024
* Hello World from the new MusicBox main().

* Python main() is producing valid floating-point output.

* Added command-line arguments.

* Write out the solution.

* Import music_box_logger the right way.

* Move log statements into main().

* Removed realistic physical defaults, replaced with None.

* Throw exception for None solver instead of Warning.

* Removed ACOM Logger. Set up music_box operation as executable script and python command line.

* Use argparse and configure it for key=value pairs.

* Revise command-line arguments to configFile and outputDir.

* pull smoke test action from other branch

* Modified to look like the MusicBox template.

* Display the working directory.

* Removed redundant pip install.

* Action test (#174)

* listing debug information

* ok actually printing wd

* trying forward slashes

* trying to join files independent of os slashes

* removing csv file

* Re-added file that was inadvertently deleted, and updated musica version tp 0.7.0

* Removed helper scripts from repository.

* Removed another batch helper script.

* Check for configFile parameter. Give error and example if not found.

* Add key=value required parameter to argparse help.

* Rename smoke test to CI Tests. Deleted test.yml.

---------

Co-authored-by: Matt Dawson <[email protected]>
Co-authored-by: Kyle Shores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants