Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue 169 air density, M third body, catch unexpected JSON #186

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

carl-drews
Copy link
Collaborator

The changes to music_box.py are similar to what Kyle has checked into the main music-branch branch already. The other changed files catch some key errors that the python code was not expecting to see in the JSON configurations.

K20shores
K20shores previously approved these changes Aug 13, 2024
boulderdaze
boulderdaze previously approved these changes Aug 13, 2024
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mattldawson
mattldawson previously approved these changes Aug 13, 2024
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just one very minor suggestion

src/acom_music_box/music_box_reaction_list.py Outdated Show resolved Hide resolved
mattldawson
mattldawson previously approved these changes Aug 13, 2024
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

boulderdaze
boulderdaze previously approved these changes Aug 13, 2024
@carl-drews
Copy link
Collaborator Author

Not sure why Build not completed:
build Expected — Waiting for status to be reported

@carl-drews carl-drews merged commit 8771053 into main Aug 13, 2024
3 checks passed
@carl-drews carl-drews deleted the 169-air-density branch August 13, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants