Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates and add Python 3.11 remove Python 3.7 and 3.8 #213

Merged
merged 15 commits into from
Feb 2, 2024

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Jun 23, 2023

Adds Python 3.11 and removes Python 3.7 and 3.8.

Other CI updates:

  • Adds nightly testing to the CI workflow
  • Changes the Conda environment creation a bit to make those work again
  • Adds a new Conda environment file we should be able to use more universally (still some work needed here)
  • Adds a macOS M1 build to the CI workflow (there a bit of a hack in the config file right now to make this work)
  • Adds Dependabot
  • Adds a docs build since the PR was complaining about this anyway (the docs need some attention though)

Required checks will need to be updated still.

Closes #212

@kafitzgerald kafitzgerald marked this pull request as draft February 1, 2024 22:28
@kafitzgerald kafitzgerald changed the title Add testing for Python 3.11 and nightly testing CI updates and add Python 3.11 remove Python 3.7 and 3.8 Feb 1, 2024
Copy link
Collaborator

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great; thanks very much for taking care of this! Please see my inline comments below

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Collaborator

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@erogluorhan erogluorhan marked this pull request as ready for review February 2, 2024 21:00
@erogluorhan erogluorhan merged commit 1f3d23d into NCAR:develop Feb 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.11 tests
2 participants