Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: perfect restart and n-cores CI #778

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Oct 23, 2024

TYPE: new feature

KEYWORDS: CI, Github Actions, perfect restart, n-cores

SOURCE: Soren Rasmussen, NSF NCAR

DESCRIPTION OF CHANGES:

  • The compare output steps have been moved to an action in .github/actions/compare-output.yml so it can be reused by the new tests
  • Two tests are added for each configuration (gridded, reach, etc.)
    • n-cores steps: clean candidate output, run in parallel, compare output
    • perfect restart steps: remove last restart file RESTART.2011090200_DOMAIN1, change namelist.hrldas to run for 1 day and to restart from ./RESTART.2011090100_DOMAIN1, then run and compare output

TESTS CONDUCTED: will have to look at the CI output to see if it looks correct 🤞

NOTES: This is setup to exit if comparison steps find a difference and not run further tests, will need to test this with test PR #747

@scrasmussen scrasmussen requested a review from rcabell October 23, 2024 22:58
@scrasmussen scrasmussen marked this pull request as draft October 23, 2024 23:02
@scrasmussen
Copy link
Member Author

Moving to draft until I fix the failure in the CI

@scrasmussen scrasmussen force-pushed the feature/perfect-restart-and-n-cores-ci branch 11 times, most recently from 89efcb9 to 0d8b67f Compare October 24, 2024 19:50
@scrasmussen scrasmussen force-pushed the feature/perfect-restart-and-n-cores-ci branch 5 times, most recently from 24b9d54 to 814b4c3 Compare November 25, 2024 18:27
@scrasmussen scrasmussen marked this pull request as ready for review November 25, 2024 18:54
@scrasmussen scrasmussen force-pushed the feature/perfect-restart-and-n-cores-ci branch 2 times, most recently from 382f4b7 to 2f3d998 Compare December 7, 2024 23:25
@rcabell rcabell force-pushed the feature/perfect-restart-and-n-cores-ci branch from 2f3d998 to 5b6a493 Compare December 10, 2024 18:14
@rcabell rcabell merged commit 644b446 into NCAR:main Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants