Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: A1 appendix now coupled WRF guide and reviewed A2 appendix #792

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Nov 20, 2024

TYPE: text only

KEYWORDS: readthedocs, documentation

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: Original A1 appendix not needed since dependencies were added to build section. A1 section has been replaced with the "Coupled WRF | WRF-Hydro V5 Test Case User Guide" pdf which has been converted to rst format, Erin Dougherty did the original review of the document before conversion.

ISSUE: #793

Copy link
Collaborator

@rcabell rcabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leaves us without an Appendix 1, which is awkward. I understand trying renumber everything afterward would be a pain, maybe we could put something else in as A1?

@scrasmussen
Copy link
Member Author

The leaves us without an Appendix 1, which is awkward. I understand trying renumber everything afterward would be a pain, maybe we could put something else in as A1?

I like this idea! Replacing A1 will just make things easier. I guess then this PR needs the other appendixes reviewed first then I'll switch one in

@scrasmussen scrasmussen force-pushed the docs/appendices-A1-A2-cleanup branch from a402ae5 to 35e9853 Compare December 7, 2024 21:50
@scrasmussen scrasmussen requested a review from rcabell December 7, 2024 21:51
@scrasmussen
Copy link
Member Author

The leaves us without an Appendix 1, which is awkward. I understand trying renumber everything afterward would be a pain, maybe we could put something else in as A1?

@rcabell Ok, the updated "Coupled WRF | WRF-Hydro V5 Test Case User Guide" that Erin edited is now Appendix 1, so that will solve that issue. This PR should be good to merge once re-reviewed

@scrasmussen scrasmussen changed the title docs: Removed A1 appendix and reviewed A2 appendix docs: A1 appendix now coupled WRF guide and reviewed A2 appendix Dec 8, 2024
@rcabell rcabell merged commit b69c231 into NCAR:main Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants