-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projection lat-lon coordinates including new GridMapping
objects
#695
Draft
sadielbartholomew
wants to merge
98
commits into
NCAS-CMS:main
Choose a base branch
from
sadielbartholomew:projections-part-1-grid-mappings-infra
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Projection lat-lon coordinates including new GridMapping
objects
#695
sadielbartholomew
wants to merge
98
commits into
NCAS-CMS:main
from
sadielbartholomew:projections-part-1-grid-mappings-infra
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Sadie - thanks for the summary - that's how I remember it, too! |
sadielbartholomew
changed the title
Projection lat-lon coordinates part 1:
Projection lat-lon coordinates including new Oct 25, 2023
GridMapping
objectsGridMapping
objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of 2 towards #628. This first part sets up the Grid Mapping class and helper function infrastructure towards interfacing with PROJ using pyproj, so that in the second part (nearly ready, but with some issues left to resolve) we can use those to invoke PROJ
cs2cs
functionality to transform from one coordinate reference system to another, else be informed that the transformation isn't valid or possible, which allows us to get the lat-lon coordinates for a given projection with corresponding CRS parameters where that makes physical sense.CF-supported Grid Mappings have been modelled explicitly as objects in this first step in order to, for example:
cf.Units
instead of having to convert to and work with PROJ formats for inputs (which are strings with a unit as a suffix e.g. "30D", "0.5R", etc.), where functions to convert to and from PROJ data and units are provided;Diagrams of new class hierarchy
Generated from this PR branch using
pyreverse -o png -p GRIDMAPPINGS-1 gridmappings.py
when in thecf
directory (large image so e.g. open out by 'Open image in new tab' or similar, click to zoom):Sadly the diagram generator doesn't seem to show abstract methods, so we don't see those. And it only show classes, so it doesn't indicate functions in the module either. But should still be useful.
I haven't done a thorough self-review yet, but we can cross-reference this with Appendix F of the Conventions doc to check everything matches up.