Fix linting errors & warnings and fix JSdocs in DataPackage (DataPackage cleanup, part 1) #334
robyngitformat-lint-test.yml
on: pull_request
Run All Checks
1m 35s
Annotations
2 errors and 1 warning
|
Run All Checks
One or more MetacatUI tests failed. Test failure details can be viewed by running "npm view-tests".
FAILS: 3
PASSES: 697
Failed Tests:
-------------
[1]: Citation Model Test Suite
> Parsing Metrics Service Response
> AssertionError: expected { literal: 'FirstName LastName' } to deeply equal { family: 'LastName', …(1) }
at Context.<anonymous> (js/specs/unit/models/CitationModel.spec.js?v=undefined:96:28)
[2]: Citation Model Test Suite
> Custom set method
> AssertionError: expected [ { literal: 'FirstName LastName' } ] to deeply equal [ { family: 'LastName', …(1) } ]
at Context.<anonymous> (js/specs/unit/models/CitationModel.spec.js?v=undefined:119:49)
[3]: Citation Model Test Suite
> Populate from SOLR model
> TypeError: Cannot read properties of undefined (reading 'should')
at Context.<anonymous> (js/specs/unit/models/CitationModel.spec.js?v=undefined:239:20)
|
|
Run All Checks
Process completed with exit code 1.
|
|
Run All Checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|