Skip to content

Commit

Permalink
Remove or deprecate unused annotation elements
Browse files Browse the repository at this point in the history
- Remove the annotationPopover template which is not used anywhere
- Deprecate propertiees and methods that have been replaced by the Bioontology model:
  - Deprecate the bioportalLookupCache property in the AppModel
  - Deprecate the following methods from the LookupModel: bioportalGetConcepts, bioportalGetConceptsBatch, bioportalSearch, bioportalExpand

Issue #1874
  • Loading branch information
robyngit committed Dec 11, 2024
1 parent 57611fe commit 3d738a3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 45 deletions.
4 changes: 2 additions & 2 deletions src/js/models/AppModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -2131,8 +2131,8 @@ define(["jquery", "underscore", "backbone"], function ($, _, Backbone) {
*/
bioportalApiBaseUrl: "https://data.bioontology.org",
/**
* This attribute stores cache of ontology information that is looked up in Bioportal, so that duplicate REST calls don't need to be made.
* @type {object}
* Make use of the Bioontology model to cache the results of Bioportal API calls
* @deprecated since 0.0.0
*/
bioportalLookupCache: {},
/**
Expand Down
3 changes: 3 additions & 0 deletions src/js/models/LookupModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ define(["jquery", "jqueryui", "underscore", "backbone"], function (
});
},

/** @deprecated */
bioportalExpand: function (term) {
// make sure we have something to lookup
if (!MetacatUI.appModel.get("bioportalAPIKey")) {
Expand Down Expand Up @@ -151,6 +152,7 @@ define(["jquery", "jqueryui", "underscore", "backbone"], function (
return terms;
},

/** @deprecated */
bioportalGetConcepts: function (uri, callback) {
var concepts = this.get("concepts")[uri];

Expand Down Expand Up @@ -200,6 +202,7 @@ define(["jquery", "jqueryui", "underscore", "backbone"], function (
});
},

/** @deprecated */
bioportalGetConceptsBatch: function (uris, callback) {
// make sure we have something to lookup
if (!MetacatUI.appModel.get("bioportalBatchUrl")) {
Expand Down
43 changes: 0 additions & 43 deletions src/js/templates/annotationPopover.html

This file was deleted.

0 comments on commit 3d738a3

Please sign in to comment.