Annotation popovers should not overlap #1874
Comments
|
@laurenwalker I agree the annotation popovers shouldn't overlap. One solution might be to ensure that only one popover is open at a time by automatically closing any that are open when someone opens one of them. I think this is good behaviour even if they don't overlap, as I've always found it strange to have to click again to close the popovers. Better if they close automatically if someone clicks on another one. How does that sound to you all? cc @amoeba @mpsaloha |
|
I've also found the popover behavior pretty strange. Popover claims to have a "focus" trigger mechanism that should do this for us but I haven't been able to make it work on Bootstrap 2.3.1 (our version). It does work as advertised on the 5.x series. @laurenwalker have you seen "focus" mode work? Making sure the two popovers can both be displayed at the same time without overlapping could be tricky but having both open at the same time might be useful. I think either doing what you suggest (only show one at a time) or merging these back into a single but much wider popover might be best:
|
|
I have seen But I like your sketch of the single popover with info about the property and value. |
laurenwalker
added
the
hacktoberfest-accepted
|
We can try using the FormaticUI popover module instead |
- Change the function paramater name from "which" to the more descriptive "popoverTarget" Issue #1874
- Consolidate some repeated code - Move logic from initalize to render method to standardize the view - Fix bug in updatePopover where the popover content property URI & label could be set to the value URI & label instead Issue #1874
Instead of the problematic bootstrap popovers Issue #1874
Instead of the problematic bootstrap popovers Issue #1874
- Replace the fetch and cache logic that was in the AnnotationView with methods from the new Bioontology model. - This fixes the cache logic which wasn't working correctly. Issue #1874
- Remove the annotationPopover template which is not used anywhere - Deprecate propertiees and methods that have been replaced by the Bioontology model: - Deprecate the bioportalLookupCache property in the AppModel - Deprecate the following methods from the LookupModel: bioportalGetConcepts, bioportalGetConceptsBatch, bioportalSearch, bioportalExpand Issue #1874
- URIs for the annotation property and value were not being detected from the DOM - This bug seems to have existed prior to the recent changes to the annotation popovers - Also ensure that the new popups are visible in all cases Issue #1874
I suggest we move the popovers so that they are not overlapping so they're both readable at the same time.
The text was updated successfully, but these errors were encountered: