Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding, removing, and changing the "canonical dataset" in the Editor #2551

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Allow adding, removing, and changing the "canonical dataset" in the Editor #2551

wants to merge 9 commits into from

Commits on Oct 15, 2024

  1. Fix linting errors in EMLAnnotations 

    Issue #2542
    @robyngit
    robyngit committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0ac3cce View commit details
    Browse the repository at this point in the history

  2. Add unit tests for the EMLAnnotations collection 

    Issue #2542
    @robyngit
    robyngit committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6189421 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Add EMLAnnotation methods for canonical datasets 

    - Add methods to add, remove, update, and find sameAs and derivedFrom annotations representing canonical datasets

Issue #2542
    @robyngit
    robyngit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    bea2d7b View commit details
    Browse the repository at this point in the history

  2. Add input for canoncial dataset in EML editor 

    - Add logic to identify the canonical dataset while parsing EML
- Update the Annotations collection with the value in the canonical dataset input changes

Issue #2542
    @robyngit
    robyngit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4df698d View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Add annotation validation to Editor 

    - Handle canonical dataset annotation errors specially so that they can be displayed in the new input field.
- Improve annotations validation to remove empty annotations and duplicates

Issue #2542
    @robyngit
    robyngit committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    877beac View commit details
    Browse the repository at this point in the history

  2. Show canonical dataset validation on value change 

    (in Editor)

Issue #2542
    @robyngit
    robyngit committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6ea1434 View commit details
    Browse the repository at this point in the history

  3. Add EMLAnnotations validation unit tests + fix 

    - Fix the findDuplicates method to return the correct result

Issue #2542
    @robyngit
    robyngit committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8368b09 View commit details
    Browse the repository at this point in the history

  4. Remove dev code 

    Issue #2542
    @robyngit
    robyngit committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4fd8ec0 View commit details
    Browse the repository at this point in the history

  5. Fix small bug in validation annotations in EML 

    And remove dev code

Issue #2542
    @robyngit
    robyngit committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    979d2a5 View commit details
    Browse the repository at this point in the history