Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Jython with Jep to enable use of modern python in checks #399

Merged
merged 65 commits into from
Mar 6, 2024
Merged

Replace Jython with Jep to enable use of modern python in checks #399

merged 65 commits into from
Mar 6, 2024

Conversation

jeanetteclark
Copy link
Collaborator

yay

dependabot bot and others added 30 commits August 16, 2023 17:41
@dependabot
Bump org.slf4j:slf4j-log4j12 from 1.6.1 to 1.7.33
03953e2 
Bumps [org.slf4j:slf4j-log4j12](https://github.com/qos-ch/slf4j) from 1.6.1 to 1.7.33.
- [Commits](qos-ch/slf4j@v_1.6.1...v_1.7.33)

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-log4j12
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump com.jayway.jsonpath:json-path from 2.4.0 to 2.8.0
6d4f762 
Bumps [com.jayway.jsonpath:json-path](https://github.com/jayway/JsonPath) from 2.4.0 to 2.8.0.
- [Release notes](https://github.com/jayway/JsonPath/releases)
- [Changelog](https://github.com/json-path/JsonPath/blob/master/changelog.md)
- [Commits](json-path/JsonPath@json-path-2.4.0...json-path-2.8.0)

---
updated-dependencies:
- dependency-name: com.jayway.jsonpath:json-path
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump org.apache.maven.plugins:maven-antrun-plugin from 1.8 to 3.1.0
007e86c 
Bumps [org.apache.maven.plugins:maven-antrun-plugin](https://github.com/apache/maven-antrun-plugin) from 1.8 to 3.1.0.
- [Commits](apache/maven-antrun-plugin@maven-antrun-plugin-1.8...maven-antrun-plugin-3.1.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-antrun-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jeanetteclark
initial replacement of jython with jep
a3b5122
@jeanetteclark
reconfigure how the jep library is found so it works on github actions
c671ea2
@jeanetteclark
fix GHA syntax
c82e512
@jeanetteclark
make sure to close the jep interpreter once we are finished
df7ff88
@jeanetteclark
split up some jep interpreter commands into their own try blocks
2938e00
@jeanetteclark
add a debug statment to gha
8105077
@jeanetteclark
use correct command to get site-packages dir
951b2f0
@jeanetteclark
change the env var name
db0255c
@jeanetteclark
more specfic way of getting the path + test it
06a2e72
@jeanetteclark
we only want the first element returned of the path
d09f743
@jeanetteclark
misplaced indexing...
ab91232
@jeanetteclark
add jep onto the path
8f5d584
@jeanetteclark
clean up a bit of code
5dca0df
@dependabot
Bump org.apache.maven.plugins:maven-shade-plugin from 3.1.0 to 3.5.1
5950a94 
Bumps [org.apache.maven.plugins:maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.1.0 to 3.5.1.
- [Release notes](https://github.com/apache/maven-shade-plugin/releases)
- [Commits](apache/maven-shade-plugin@maven-shade-plugin-3.1.0...maven-shade-plugin-3.5.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-shade-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@jeanetteclark
switch to subinterpreter and don't close the interpreter
e2de386 
gotta figure out how to close correctly later
@jeanetteclark
format document, and make sure to not carry forward results
6b007e3
@jeanetteclark
make test look more like python checks
632dc58
@jeanetteclark
upgrade jep and remove jython
0dc09d0
@jeanetteclark
remove last (unused) reference to jython
2aeeabb
@jeanetteclark
move jep script engine classes into their own files
6242889
@jeanetteclark
close the dispatcher in the main method after running the last check
a51a9a3
@jeanetteclark
update a test with the new pattern
d8ad565
@jeanetteclark
more test updates
0a816fc
@jeanetteclark
Revert "more test updates"
8396c3d 
This reverts commit 0a816fc.
@jeanetteclark
Revert "update a test with the new pattern"
acf0062 
This reverts commit d8ad565.
@jeanetteclark
Revert "close the dispatcher in the main method after running the las…
cc42268 
…t check"

This reverts commit a51a9a3.
@jeanetteclark
add debugging config
9870275
@jeanetteclark
fix the jdk path
3fa98a6
@jeanetteclark
maybe this is what it's called
5f26516
@jeanetteclark
upgrade spring
2169118
@jeanetteclark
only convert numeric looking things if they don't have a leading 0
7a87866
@jeanetteclark
update the maven compiler plugin
6f57094
@jeanetteclark
make sure to bind the completed queue
6f2ff7f
@jeanetteclark
nevermind can't bind that queue
fcea330
@jeanetteclark
add jep path to metadig.properties
4d47e93
@jeanetteclark
update NSF API endpoint
2f4dd3f
@jeanetteclark
fix nsf award check to handle the API output
813bb5e
@jeanetteclark
use the ADC proxy
655afaf
@jeanetteclark
improve exception handling and parsing logic
d112780
@jeanetteclark
Merge branch 'dependabot/maven/develop/org.slf4j-slf4j-log4j12-1.7.33…
f697055 
…' into feature-jep
@jeanetteclark
Merge branch 'dependabot/maven/develop/com.jayway.jsonpath-json-path-…
ec35e29 
…2.8.0' into feature-jep
@jeanetteclark
Merge branch 'dependabot/maven/develop/org.apache.maven.plugins-maven…
fb14462 
…-antrun-plugin-3.1.0' into feature-jep
@jeanetteclark
Merge branch 'dependabot/maven/develop/org.apache.maven.plugins-maven…
0f31b29 
…-shade-plugin-3.5.1' into feature-jep
artntek
artntek requested changes Feb 12, 2024
View reviewed changes
bin/sendAssessmentTest.py Outdated Show resolved Hide resolved
bin/sendAssessmentTest.py Outdated Show resolved Hide resolved
bin/startWorker.sh Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/dispatch/Dispatcher.java Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/dispatch/Dispatcher.java Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/processor/XMLDialect.java Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/processor/XMLDialect.java Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/processor/XMLDialect.java Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/processor/XMLDialect.java Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/processor/XMLDialect.java Outdated Show resolved Hide resolved
artntek
artntek approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@artntek artntek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small typo to change. I approved

@jeanetteclark jeanetteclark merged commit 7d0c7de into develop Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artntek artntek artntek approved these changes

@mbjones mbjones Awaiting requested review from mbjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanetteclark @artntek