-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft-api: Update priority field #334
Conversation
katrinewi
commented
Nov 10, 2023
- Oppdaterer prioritized navngivning til priority
- Oppdaterer priority til å kunne ta følgende verdier: prioritized, on-hold(parkert) eller unspecified
- Legger til migrering som oppdaterer prioritized-felt
6b76676
to
435c3ca
Compare
- Change naming prioritized -> priority - Update priority to either be prioritized, on-hold or unspecified - Add migration to update articles
435c3ca
to
657b155
Compare
search-api/src/main/scala/no/ndla/searchapi/model/api/MultiSearchSummary.scala
Outdated
Show resolved
Hide resolved
4ca4343
to
9d642f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette er veldig breaking mot ed. Vi gjør det enklere for oss sjølv om vi i stedet for å bytte ut prioritized heller legger til priority ved siden av. Då er vi ikkje avhengig av å måtte deploye draft-api og ed samtidig.
common/src/main/scala/no/ndla/common/model/domain/Priority.scala
Outdated
Show resolved
Hide resolved
draft-api/src/main/scala/no/ndla/draftapi/model/api/Article.scala
Outdated
Show resolved
Hide resolved
search-api/src/main/scala/no/ndla/searchapi/service/search/DraftIndexService.scala
Outdated
Show resolved
Hide resolved
search-api/src/main/scala/no/ndla/searchapi/service/search/SearchConverterService.scala
Outdated
Show resolved
Hide resolved
search-api/src/main/scala/no/ndla/searchapi/service/search/SearchConverterService.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funker med gammel ed, så lgtm. Dvs har kun sett på at det funker. Gjør som Jonas seier . :)
revision = 1, | ||
language = None, | ||
title = None, | ||
status = None, | ||
published = None, | ||
content = None, | ||
tags = None, | ||
introduction = None, | ||
metaDescription = None, | ||
metaImage = Right(None), | ||
visualElement = None, | ||
copyright = None, | ||
requiredLibraries = None, | ||
articleType = None, | ||
notes = None, | ||
editorLabels = None, | ||
grepCodes = None, | ||
conceptIds = None, | ||
createNewVersion = None, | ||
availability = None, | ||
relatedContent = None, | ||
revisionMeta = None, | ||
responsibleId = Right(None), | ||
slug = None, | ||
comments = None, | ||
prioritized = None, | ||
priority = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Litt lettere å lese!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM