Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft-api: Update priority field #334

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Conversation

katrinewi
Copy link
Contributor

  • Oppdaterer prioritized navngivning til priority
  • Oppdaterer priority til å kunne ta følgende verdier: prioritized, on-hold(parkert) eller unspecified
  • Legger til migrering som oppdaterer prioritized-felt

@katrinewi katrinewi force-pushed the add_on_hold_field_on_draft branch 2 times, most recently from 6b76676 to 435c3ca Compare November 10, 2023 11:53
- Change naming prioritized -> priority
- Update priority to either be prioritized, on-hold or unspecified
- Add migration to update articles
@katrinewi katrinewi force-pushed the add_on_hold_field_on_draft branch from 435c3ca to 657b155 Compare November 10, 2023 11:59
@katrinewi katrinewi force-pushed the add_on_hold_field_on_draft branch from 4ca4343 to 9d642f0 Compare November 10, 2023 12:46
@katrinewi katrinewi marked this pull request as ready for review November 10, 2023 13:10
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette er veldig breaking mot ed. Vi gjør det enklere for oss sjølv om vi i stedet for å bytte ut prioritized heller legger til priority ved siden av. Då er vi ikkje avhengig av å måtte deploye draft-api og ed samtidig.

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funker med gammel ed, så lgtm. Dvs har kun sett på at det funker. Gjør som Jonas seier . :)

Comment on lines +117 to +143
revision = 1,
language = None,
title = None,
status = None,
published = None,
content = None,
tags = None,
introduction = None,
metaDescription = None,
metaImage = Right(None),
visualElement = None,
copyright = None,
requiredLibraries = None,
articleType = None,
notes = None,
editorLabels = None,
grepCodes = None,
conceptIds = None,
createNewVersion = None,
availability = None,
relatedContent = None,
revisionMeta = None,
responsibleId = Right(None),
slug = None,
comments = None,
prioritized = None,
priority = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litt lettere å lese!

@katrinewi katrinewi requested a review from jnatten November 13, 2023 15:26
Copy link
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katrinewi katrinewi merged commit 0a0cf3b into master Nov 14, 2023
@katrinewi katrinewi deleted the add_on_hold_field_on_draft branch November 14, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants