Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-alt attribute to iframe embed #337

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Nov 14, 2023

https://trello.com/c/3ZHUqmuT/84-kan-ikke-redigere-alt-tekst-for-bilde-som-settes-i-boks-for-ekstern-ressurs

Satt kun opp imageid som dependant. Blir det riktig at jeg ikke lister opp data-alt i mustCoexistWith på de andre attributene? Den er tross alt ikke required.

@Jonas-C Jonas-C requested a review from a team November 14, 2023 15:19
Copy link
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Så lenge den ikke er required så ser det riktig ut for meg ✌️

@gunnarvelle
Copy link
Member

Sånn det er no kan du sette imageid uten å sette alt, men ikkje alt uten å sette imageid. Om det er det du ville så er det ok.

@Jonas-C
Copy link
Contributor Author

Jonas-C commented Nov 15, 2023

Sånn det er no kan du sette imageid uten å sette alt, men ikkje alt uten å sette imageid. Om det er det du ville så er det ok.

Ja, blir ikke det riktig?

@gunnarvelle
Copy link
Member

Ja, blir ikke det riktig?

Du veit vel best kva du prøvde på.

@Jonas-C Jonas-C merged commit be8fbca into master Nov 15, 2023
10 checks passed
@Jonas-C Jonas-C deleted the add-data-alt-to-iframe-embed branch November 15, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants