-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint to transcribe videos #554
Conversation
ekrojo77
commented
Dec 5, 2024
•
edited
Loading
edited
- Testing
- Endepunkt for å polle om filen er opprettet
- Bedre return fra GET
case Success(_) => Right(()) | ||
case Failure(ex) => returnLeftError(ex) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beholder disse i første omgang før vi vet hva som trengs av endepunkt. Men tror det rene transcribe-endepunktet er det som vil bli mest brukt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lisenspirk
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/model/api/TranscriptionResultDTO.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Show resolved
Hide resolved
audio-api/src/test/scala/no/ndla/audioapi/service/TranscriptionServiceTest.scala
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/AudioApiProperties.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/AudioApiProperties.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/controller/TranscriptionController.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Outdated
Show resolved
Hide resolved
audio-api/src/main/scala/no/ndla/audioapi/service/TranscriptionService.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/no/ndla/common/brightcove/NdlaBrightcoveClient.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nå!
Har ikke testa at funksjonaliteten gjør det den skal gjøre, men det gjør vi kanskje senere med ed inn i bildet uansett?
Ja alt annet enn videoer testes via ed. Men det er nok et steg senere uansett - så det er bare laget for fremtidig implementasjon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm