Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint to transcribe videos #554

Merged
merged 36 commits into from
Jan 15, 2025
Merged

Endpoint to transcribe videos #554

merged 36 commits into from
Jan 15, 2025

Conversation

ekrojo77
Copy link
Contributor

@ekrojo77 ekrojo77 commented Dec 5, 2024

  • Testing
  • Endepunkt for å polle om filen er opprettet
  • Bedre return fra GET

case Success(_) => Right(())
case Failure(ex) => returnLeftError(ex)
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beholder disse i første omgang før vi vet hva som trengs av endepunkt. Men tror det rene transcribe-endepunktet er det som vil bli mest brukt

@ekrojo77 ekrojo77 marked this pull request as ready for review December 13, 2024 10:37
@ekrojo77 ekrojo77 requested a review from a team December 13, 2024 10:37
@ekrojo77 ekrojo77 marked this pull request as draft December 13, 2024 13:53
@ekrojo77 ekrojo77 changed the title Endpoint to extract audio from brightcove files Endpoint to transcribe videos Dec 13, 2024
@ekrojo77 ekrojo77 marked this pull request as ready for review December 16, 2024 10:43
@ekrojo77 ekrojo77 marked this pull request as draft December 17, 2024 13:19
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lisenspirk

@ekrojo77 ekrojo77 marked this pull request as ready for review January 2, 2025 10:38
@ekrojo77 ekrojo77 requested a review from jnatten January 8, 2025 06:40
@ekrojo77 ekrojo77 requested a review from jnatten January 10, 2025 07:13
Copy link
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nå!
Har ikke testa at funksjonaliteten gjør det den skal gjøre, men det gjør vi kanskje senere med ed inn i bildet uansett?

@ekrojo77
Copy link
Contributor Author

LGTM nå! Har ikke testa at funksjonaliteten gjør det den skal gjøre, men det gjør vi kanskje senere med ed inn i bildet uansett?

Ja alt annet enn videoer testes via ed. Men det er nok et steg senere uansett - så det er bare laget for fremtidig implementasjon

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ekrojo77 ekrojo77 merged commit d2c98c5 into master Jan 15, 2025
25 checks passed
@ekrojo77 ekrojo77 deleted the transcribe-audio branch January 15, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants