Capture logs during testing and print them in case of failure #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a new feature of the `UnitTestSuite`: When tests are ran we collect logs for the `no.ndla` package in a buffer, and when a test fails the collected logs are printed for that test in particular. This allows us to keep clean and readable logs when tests are green, but will allow us to more easily find mistakes when a test fails.
Previously we just let the default scala runner handle printing exceptions during startup. This works fine for most cases, but when we want to capture logs in a test this does not get logged and captured.
This resulted in captured logs not appearing correctly
This resulted in captured logs not appearing correctly
While this is still not perfect (We will still log exceptions two times on exit), the code itself is cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dette er en ting jeg har tenkt på før, men fikk litt ny giv når @katrinewi støtte på en migreringsfeil som ikke var så lett å tolke ut av testene i dag.
Sånn det er før denne PR'en:
Sånn det er i denne PR'en:
beforeAll+ testen) bli printet til konsollen.Det ser sånn ca sånn her ut: