Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automagic copyright generation #598

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Automagic copyright generation #598

merged 7 commits into from
Feb 7, 2025

Conversation

jnatten
Copy link
Contributor

@jnatten jnatten commented Feb 6, 2025

Legger til en sbt plugin som har to tasks:

  • sbt copyrightCheck: som kaster feil om noen av copyrightene i matcher forventet oppsett
  • sbt copyrightGenerate: som skriver over alle filer med fikset copyright
    Legger også til å kjøre copyrightCheck på ci.

Siden denne endrer så uendelig mange filer så anbefaler jeg å reviewe commit for commit 🤓

@jnatten jnatten requested a review from a team February 6, 2025 13:36
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kun et spørsmål

val sourceFiles: Seq[File] = (Compile / sources).value
val testFiles: Seq[File] = (Test / sources).value
val allFiles = sourceFiles ++ testFiles
val filteredPath = s"/$appName/target/scala-2.13/src_managed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er det ingen risiko for at denne pathen endres?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tja den kan jo kanskje det dersom scalatsi pluginen endrer versjon.
Kan kanskje sjekke etter alt som er i target når jeg tenker meg om.

@jnatten jnatten merged commit 0867c07 into master Feb 7, 2025
21 checks passed
@jnatten jnatten deleted the copyright-generation branch February 7, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants