Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Don't ask again" #114

Closed
petersalomonsen opened this issue Jun 14, 2024 · 3 comments
Closed

Support "Don't ask again" #114

petersalomonsen opened this issue Jun 14, 2024 · 3 comments

Comments

@petersalomonsen
Copy link
Contributor

The "Don't ask again" feature does not work with the BOS-workspace gateway.

image

As you can see it is only displaying "Don't ask again for sending similar transactions by", and that's all, but it should also show the widget name.

The reason for this is because of using the redirectmap, and the fix would be to make sure that the RPC proxy intercepts and replaces requests for widget source code with local content ( and stop using the redirectmap ). I know this will work, since I've already tested it in the DevHub playwright tests.

@elliotBraem
Copy link
Contributor

elliotBraem commented Jun 14, 2024

Local gateway is hardcoded with proxy RPC requests (see here)

But is also configured for redirect map here. This is only used for hot reload -- hot reload can be disabled via "bos-workspace dev --no-hot"

Try disabling hot reload and see if it works then

@petersalomonsen
Copy link
Contributor Author

even with --no-hot I get this:

image

@elliotBraem
Copy link
Contributor

This is resolved now with #115, --no-hot will not trigger redirectMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants