Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

121 support deploy metadata #140

Merged
merged 10 commits into from
Jul 17, 2024
Merged

121 support deploy metadata #140

merged 10 commits into from
Jul 17, 2024

Conversation

bb-face
Copy link
Collaborator

@bb-face bb-face commented Jul 17, 2024

Resolves #121

This PR adds the function to upload metadata to the social db.
I also added the support for the option --signerPublicKey and --signerPrivateKey in order to sign the transaction without any user input!

bb-face added 3 commits July 16, 2024 16:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bb-face bb-face linked an issue Jul 17, 2024 that may be closed by this pull request
@bb-face bb-face requested a review from elliotBraem July 17, 2024 14:54
@@ -1,7 +1,7 @@
{
"account": "quickstart.near",
"account": "bbface.near",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

@@ -0,0 +1,15 @@
{
"name": "Tree version 2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this tho

hahah tree version 2

Maybe rename -- single/home is just a BOS implementation of Guest Book

https://github.com/near-examples/guest-book-examples

lib/deploy.ts Outdated
"contract",
"call-function",
"as-transaction",
"social.near",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

social.near in mainnet, v1.social08.testnet in testnet (I think there is a definition that can be exported from server.ts)

lib/deploy.ts Outdated
"sign-as",
account,
"network-config",
"mainnet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this come from network -n

lib/deploy.ts Outdated

if (BOS_SIGNER_PUBLIC_KEY && BOS_SIGNER_PRIVATE_KEY) command = command.concat(automaticSignIn)

// { "data": { "bbface.near": { "widget": { "test": { "": "return <p>hello world</p>;", "metadata": { "name": "test" } } } } } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

lib/cli.ts Outdated
console.log("not yet supported");
.description("Upload data to SocialDB")
.argument("[string]", "app path")
.argument("[string]", "account")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about, for consistency:

.argument("[src]", "path to the app source code", ".")

And then account can be derived from config of the app source code, right? But I think this is okay for now, we can adjust when we combine with deploy

@elliotBraem
Copy link
Contributor

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Jul 17, 2024

@bb-face Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@elliotBraem 2

The average score is 2

@bb-face check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@elliotBraem
Copy link
Contributor

@race-of-sloths score 2

@race-of-sloths
Copy link

🌟 Score recorded!

@elliotBraem, thank you for scoring this pull request in the Race of Sloths!

bb-face added 3 commits July 17, 2024 21:48
@elliotBraem elliotBraem marked this pull request as ready for review July 17, 2024 20:36
@elliotBraem elliotBraem merged commit 0151567 into main Jul 17, 2024
1 check passed
@elliotBraem elliotBraem deleted the 121-support-deploy-metadata branch July 17, 2024 20:36
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 2!
You have received 30 (20 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @bb-face! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deploy metadata
3 participants