-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
121 support deploy metadata #140
Conversation
examples/single/bos.config.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"account": "quickstart.near", | |||
"account": "bbface.near", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this
@@ -0,0 +1,15 @@ | |||
{ | |||
"name": "Tree version 2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this tho
hahah tree version 2
Maybe rename -- single/home is just a BOS implementation of Guest Book
lib/deploy.ts
Outdated
"contract", | ||
"call-function", | ||
"as-transaction", | ||
"social.near", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
social.near in mainnet, v1.social08.testnet in testnet (I think there is a definition that can be exported from server.ts)
lib/deploy.ts
Outdated
"sign-as", | ||
account, | ||
"network-config", | ||
"mainnet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have this come from network -n
lib/deploy.ts
Outdated
|
||
if (BOS_SIGNER_PUBLIC_KEY && BOS_SIGNER_PRIVATE_KEY) command = command.concat(automaticSignIn) | ||
|
||
// { "data": { "bbface.near": { "widget": { "test": { "": "return <p>hello world</p>;", "metadata": { "name": "test" } } } } } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
lib/cli.ts
Outdated
console.log("not yet supported"); | ||
.description("Upload data to SocialDB") | ||
.argument("[string]", "app path") | ||
.argument("[string]", "account") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about, for consistency:
.argument("[src]", "path to the app source code", ".")
And then account can be derived from config of the app source code, right? But I think this is okay for now, we can adjust when we combine with deploy
…-support-deploy-metadata
@bb-face Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 2 @bb-face check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
@race-of-sloths score 2 |
🌟 Score recorded!@elliotBraem, thank you for scoring this pull request in the Race of Sloths! |
✅ PR is finalized!Your contribution is much appreciated with a final score of 2! Another weekly streak completed, well done @bb-face! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths |
Resolves #121
This PR adds the function to upload metadata to the social db.
I also added the support for the option
--signerPublicKey
and--signerPrivateKey
in order to sign the transaction without any user input!