Feat/deploy #82
Feat/deploy #82
Conversation
| console.log("not yet supported"); | ||
| .description("Deploy the project") | ||
| .argument("[string]", "Workspace app name to deploy") | ||
| .option("--deploy-account-id <deployAccountId>", "Account under which component code should be deployed") |
There was a problem hiding this comment.
This all looks good, can you run bw help and update the README with this new command?
tests/unit/deploy.ts
Outdated
| global.log = unmockedLog; | ||
| }) | ||
|
|
||
| it('should build correctly without logs', async () => { |
There was a problem hiding this comment.
I like how you've set up these tests so far -- for test cases, I'm thinking:
- should match expected input for bos-cli-rs (src/widget -> src), isolate that function in code call it "translate"
- should exec with correct command -> compare the the exec method call after running deployApp
lib/deploy.ts
Outdated
|
|
||
| const config = await readConfig(path.join(src, "bos.config.json"), opts.network); | ||
|
|
||
| // Move files from "src/widget" to "src/" |
There was a problem hiding this comment.
Looks great, how about moving L25-53 to a "translate" or "translateForBosCli" function so we can test it?
|
Resolve #77 |
tests/unit/build.ts
Outdated
| @@ -47,9 +47,9 @@ const app_example_1_output = { | |||
| "/build/ipfs.json": JSON.stringify({ | |||
| "logo.svg": "QmHash", | |||
| }, null, 2) + "\n", | |||
| "/build/src/widget/hello.utils.module.js": "const hello = (name) => `Hello, ${name}!`;\nreturn { hello };\n", | |||
| "/build/src/widget/hello/utils.module.js": "const hello = (name) => `Hello, ${name}!`;\nreturn { hello };\n", | |||
There was a problem hiding this comment.
It should be a dot, not /
tests/unit/build.ts
Outdated
| "/build/src/widget/index.jsx": "const hello = \"hi\";\nreturn hello(props);\n", | ||
| "/build/src/widget/nested.index.jsx": "const hello = \"hi\";\nreturn hello(props);\n", | ||
| "/build/src/widget/nested/index.jsx": "const hello = \"hi\";\nreturn hello(props);\n", |
tests/unit/build.ts
Outdated
| @@ -118,7 +118,7 @@ const app_example_2_output = { | |||
| "/build/ipfs.json": JSON.stringify({ | |||
| "logo.svg": "QmHash", | |||
| }, null, 2) + "\n", | |||
| "/build/src/widget/hello.utils.module.js": "const hello = (name) => `Hello, ${name}!`;\nreturn { hello };\n", | |||
| "/build/src/widget/hello/utils.module.js": "const hello = (name) => `Hello, ${name}!`;\nreturn { hello };\n", | |||
| "/build/src/widget/index.jsx": "const hello = \"hi\";\nreturn hello(props);\n", | |||
|
From testing it out locally deploy single
Although I did not provide any signing details, I still see a log for "App deployed successfully". I would expect a message that says "Necessary values not provided, please provide private & public key for deploy" 
Otherwise works well deploy multi
Although I am in a multi and I didn't provide an app name, it still attempts to deploy; it stalls on "deploying app"; we should stop it if in a workspace (has
|
Draft #77