Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code base #38

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Refactor the code base #38

merged 9 commits into from
Apr 12, 2024

Conversation

ckshitij
Copy link
Collaborator

@ckshitij ckshitij commented Apr 1, 2024 •
edited
Loading

  • Update the parameter ownership
  • Add Error handling and propagate it to examples.
  • Fix workflow failure.

jaswinder6991
jaswinder6991 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@jaswinder6991 jaswinder6991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor is in progress. Will not cut a new release with these changes. Will wait for more refactors coming up.

@jaswinder6991 jaswinder6991 merged commit 6429f3d into NEARBuilders:main Apr 12, 2024
1 check passed
@ckshitij ckshitij deleted the feature/enhance-code-quality branch April 27, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaswinder6991 jaswinder6991 jaswinder6991 approved these changes

@qarmitage qarmitage Awaiting requested review from qarmitage

@naveensharmaswe naveensharmaswe Awaiting requested review from naveensharmaswe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckshitij @jaswinder6991