Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roll call related code #242

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Remove roll call related code #242

merged 5 commits into from
Jan 31, 2025

Conversation

kevinlee-06
Copy link
Member

Description

This PR addresses the removal of the unimplemented roll call button from the OtherPage UI. The roll call feature is currently not available, and this change helps to clean up the interface by removing references to it.

Implementation

  • Removed the rollCallRemind enum value from OnListViewPress.
  • Commented out the related UI elements and event logging code for the roll call feature in the _OtherPageState class.
  • Ensured that no references to the roll call feature remain in the codebase.

Testing Instructions

Please provide details on the steps required to review and test this PR.

  • Review the other_page.dart file to confirm that all references to the roll call feature have been removed or commented out.
  • Run the application and navigate to the OtherPage to ensure that the roll call button is no longer displayed.
  • Verify that the application functions correctly without any errors related to the removed feature.

Additional Notes

This change is part of a larger effort to streamline the user interface and remove features that are not yet implemented. Future updates will include the reintroduction of the roll call feature once it is fully developed.

Copy link
Member

@rileychh rileychh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and works well on my Pixel 7.
Works on my machine

@rileychh rileychh changed the title fix: remove unimplemented roll call button Remove roll call related code Jan 30, 2025
@kevinlee-06 kevinlee-06 merged commit e6b5a61 into master Jan 31, 2025
4 checks passed
@kevinlee-06 kevinlee-06 deleted the remove-roll-call branch January 31, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants