FW-526: live cosmos data payload MVP #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richjam
reviewed
Jan 16, 2025
| oracle = await Oracle.create( | ||
| oracle_creds["dsn"], oracle_creds["user"], oracle_creds["pass"] | ||
| ) | ||
| tables = [CosmosTable.LEVEL_1_SOILMET_30MIN, CosmosTable.LEVEL_1_NMDB_1HOUR] |
There was a problem hiding this comment.
Can this not just be all the tables in the enum?
There was a problem hiding this comment.
It can be, but it takes a frustrating amount of time to get unique site IDs from the PRECIP datasets which slowed down testing a lot. I'm entertaining the possibility that the table will be a command line argument to run the script because the PRECIP datasets are likely to take much longer to send out
There was a problem hiding this comment.
I was going to comment on this, but it doesn't seem the best way to get the SITE IDs to me... Can we not just query the SITES table to get all site ids?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the base changes needed to forward live data from the Cosmos Database. The scope of these changes goes from interfacing with the database up to the construction of payloads that may be deposited into AWS.
Changes