-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FW-527: AWS upload #13
Conversation
Created data model for CR1000X payload
…ture/FW-527-aws-upload
test_db, test_messaging, and test_devices are being skipped because it requires config.cfg to exist. Is this still valid, given the docs tell user to create the config file as oracle.cfg? |
The config file was used to link into the Cosmos database for testing and comes from a time when I didn't know I could mimick the connections through mocking. It shouldn't impact the |
In logger.debug(f"site {site} not in state. Using fallback time {self._fallback_time}.") |
Should/could the fallback time be a command line arg, for testing purposes (and if we wanted to send a bigger chunk of data?) Or the timedelta hours? |
Args: | ||
config_src: A path to the config.cfg file used. | ||
table: A list of tables to upload from. | ||
site: A list of sites to upload from. Grabs sites from the Oracle database if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
site: A list of sites to upload from. Grabs sites from the Oracle database if | |
sites: A list of sites to upload from. Grabs sites from the Oracle database if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is supposed to be site
so that you add sites in the CLI like --site SITE1 --site SITE2
. It felt odd to have them be plural each time
This has been added as an argument now |
Makes the changes needed to track the latest data sent to AWS and send only new data.
Changes