Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add numerical aperture #123

Merged
merged 6 commits into from
May 13, 2024
Merged

add numerical aperture #123

merged 6 commits into from
May 13, 2024

Conversation

Zack-83
Copy link
Collaborator

@Zack-83 Zack-83 commented May 3, 2024

Solves #76

@Zack-83 Zack-83 requested a review from StroemPhi May 3, 2024 08:58
@Zack-83 Zack-83 linked an issue May 3, 2024 that may be closed by this pull request
[NTR] add "numerical aperture" #76
Closed
@StroemPhi
Copy link
Member

Thank you @Zack-83, will review next week!

StroemPhi
StroemPhi approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@StroemPhi StroemPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will put the Wikipedia reference and the corresponding CHARISMA wikilink as the definition source when I assign the term ID.

@StroemPhi StroemPhi merged commit cc7c6ba into main May 13, 2024
1 check passed
@StroemPhi StroemPhi deleted the 76-ntr-add-numerical-aperture branch May 13, 2024 08:50
@StroemPhi StroemPhi mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StroemPhi StroemPhi StroemPhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR] add "numerical aperture"
2 participants
@Zack-83 @StroemPhi