Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: workflows #137

Merged
merged 1 commit into from
Aug 29, 2023
Merged

refactor: workflows #137

merged 1 commit into from
Aug 29, 2023

Conversation

hamed-musallam
Copy link
Collaborator

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think brancher-ignore is required here
instead we can just keep below.

on:
    pull_request:
        branches:
               - development

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need those tests to run once i push a commit on a branch, we can remove pull_request if you want and keep the on push

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go ahead with this for now.. If required we can remove later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go ahead with this for now.. If required we can remove later

@NishaSharma14 NishaSharma14 merged commit 4f3248d into development Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants