Handle empty strings in tag/field values (#3)

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v0.11.4
+
+- Handle empty strings in tag/field values
+
 ## v0.11.3
 
 - Handle nils, atoms, lists and maps in tag/field keys/values

lib/fluxter/packet.ex

@@ -50,7 +50,13 @@ defmodule Fluxter.Packet do
   defp encode_key(nil), do: "nil"
 
   defp encode_key(val) do
-    to_string(val) |> escape(' ,')
+    val
+    |> to_string()
+    |> String.trim()
+    |> case do
+      "" -> "empty"
+      other -> to_string(other) |> escape(' ,')
+    end
   end
 
   defp encode_value(nil), do: inspect("nil")
@@ -67,7 +73,12 @@ defmodule Fluxter.Packet do
         Atom.to_string(val)
 
       is_binary(val) ->
-        [?\", escape(val, '"'), ?\"]
+        val
+        |> String.trim()
+        |> case do
+          "" -> "empty"
+          other -> [?\", escape(other, '"'), ?\"]
+        end
 
       true ->
         val

test/fluxter_test.exs

@@ -158,6 +158,26 @@ defmodule FluxterTest do
       assert_receive {:echo, "foo,bar=baz,qux=baz value=\"nil\""}
     end
 
+    test "empty string tag" do
+      TestFluxter.write("foo", [bar: "baz", qux: "baz", empty: ""], 0)
+      assert_receive {:echo, "foo,bar=baz,empty=empty,qux=baz value=0i"}
+    end
+
+    test "only spaces in tag" do
+      TestFluxter.write("foo", [bar: "baz", qux: "baz", empty: "     "], 0)
+      assert_receive {:echo, "foo,bar=baz,empty=empty,qux=baz value=0i"}
+    end
+
+    test "empty string field" do
+      TestFluxter.write("foo", "")
+      assert_receive {:echo, "foo value=empty"}
+    end
+
+    test "only spaces in field" do
+      TestFluxter.write("foo", "    ")
+      assert_receive {:echo, "foo value=empty"}
+    end
+
     test "atom field" do
       TestFluxter.write("foo", [bar: "baz", qux: "baz"], :atom)
       assert_receive {:echo, "foo,bar=baz,qux=baz value=\":atom\""}