Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gulp file read endless waiting #7826

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bmwz110
Copy link
Contributor

@bmwz110 bmwz110 commented Feb 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If build-config.js does not exist, the gulp command will cause endless waiting

What is the new behavior?

When the search reaches the end of the file system and still does not find the target file, then throw an error

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 7, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #7826 (2712d6d) into master (3602abc) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2712d6d differs from pull request most recent head 955fce3. Consider uploading reports for the commit 955fce3 to get more accurate results

@@            Coverage Diff             @@
##           master    #7826      +/-   ##
==========================================
+ Coverage   92.08%   92.09%   +0.01%     
==========================================
  Files         502      502              
  Lines       16819    16819              
  Branches     2577     2662      +85     
==========================================
+ Hits        15487    15489       +2     
+ Misses       1061     1060       -1     
+ Partials      271      270       -1     
Impacted Files Coverage Δ
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor Author

@bmwz110 bmwz110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better: replace console's "build-config.js" to ${BUILD_CONFIG_FILENAME}

@wzhudev
Copy link
Member

wzhudev commented Feb 17, 2023

Could you please a reproduction? What's the problem this PR supposed to solve?

@bmwz110
Copy link
Contributor Author

bmwz110 commented Feb 24, 2023

build-config.js

Yes:
remove build-config.js (or rename it) from folder and run gulp, terminal did not output any prompts, I mistakenly thought it was in progress, until it took longer.

This is just a corner problem I encountered when learning this framework, I forget set build-config.js.
This PR can help developers locate problems faster.

scripts/build-config.ts Outdated Show resolved Hide resolved
Complete this pull request: support judging the root directory of different system environments.
@bmwz110 bmwz110 changed the title fix gulp file read endless waiting fix: gulp file read endless waiting Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants