Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:typography): more edit triggers #8420

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently editable texts in the Typography section only support edit icon as their trigger, as Ant design's triggers include icon, text and both.

What is the new behavior?

Described above.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

@ParsaArvanehPA ParsaArvanehPA requested a review from hsuanxyz as a code owner March 1, 2024 22:11
Copy link

zorro-bot bot commented Mar 1, 2024

This preview will be available after the AzureCI is passed.

@@ -68,6 +73,7 @@ export class NzTextEditComponent implements OnInit {

@Input() text?: string;
@Input() icon: NzTSType = 'edit';
@Input() nzTriggerType: NzEditTriggerState = 'icon';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to antd's API definition, TriggerType should be an array type:

type NzEditTriggerState = ('icon' | 'text')[];

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the test pass :)

@ParsaArvanehPA
Copy link
Contributor Author

Make the test pass :)

Hi @Nicoss54
Sorry for the long delay, I will get back to you as soon as possible

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (13e8a45) to head (816c62b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8420      +/-   ##
==========================================
- Coverage   91.50%   91.50%   -0.01%     
==========================================
  Files         534      534              
  Lines       18408    18414       +6     
  Branches     2904     2905       +1     
==========================================
+ Hits        16844    16849       +5     
  Misses       1243     1243              
- Partials      321      322       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants