-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:typography): more edit triggers #8420
base: master
Are you sure you want to change the base?
feat(module:typography): more edit triggers #8420
Conversation
This preview will be available after the AzureCI is passed. |
@@ -68,6 +73,7 @@ export class NzTextEditComponent implements OnInit { | |||
|
|||
@Input() text?: string; | |||
@Input() icon: NzTSType = 'edit'; | |||
@Input() nzTriggerType: NzEditTriggerState = 'icon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to antd's API definition, TriggerType should be an array type:
type NzEditTriggerState = ('icon' | 'text')[];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the test pass :)
Hi @Nicoss54 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8420 +/- ##
==========================================
- Coverage 91.50% 91.50% -0.01%
==========================================
Files 534 534
Lines 18408 18414 +6
Branches 2904 2905 +1
==========================================
+ Hits 16844 16849 +5
Misses 1243 1243
- Partials 321 322 +1 ☔ View full report in Codecov by Sentry. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently editable texts in the Typography section only support edit icon as their trigger, as Ant design's triggers include icon, text and both.
What is the new behavior?
Described above.
Does this PR introduce a breaking change?
Other information