Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:*): remove method parameter decorators #8567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

逐步迁移到标准装饰器,作为第一步,移除所有方法参数装饰器。

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Jun 4, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 97.13262% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.50%. Comparing base (9c6e4bf) to head (21e8965).
Report is 8 commits behind head on master.

Files Patch % Lines
components/code-editor/code-editor.service.ts 0.00% 2 Missing ⚠️
components/tabs/tab-link.directive.ts 33.33% 2 Missing ⚠️
components/back-top/back-top.component.ts 66.66% 0 Missing and 1 partial ⚠️
components/dropdown/dropdown-button.directive.ts 0.00% 1 Missing ⚠️
components/table/src/table/tbody.component.ts 66.66% 1 Missing ⚠️
components/tabs/tabset.component.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8567      +/-   ##
==========================================
- Coverage   91.51%   91.50%   -0.01%     
==========================================
  Files         534      534              
  Lines       18425    18404      -21     
  Branches     2905     2904       -1     
==========================================
- Hits        16861    16841      -20     
+ Misses       1244     1242       -2     
- Partials      320      321       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 requested review from Laffery and Nicoss54 and removed request for danranVm, OriginRing and Laffery June 15, 2024 09:55
@Nicoss54
Copy link
Collaborator

@HyperLife1119 review in progress :)

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54
Copy link
Collaborator

@HyperLife1119 please resolve the conflitcts then it willbe good

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants