Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): updated the condition for displaying nz-pagination… #8628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gitkhartmann
Copy link

… when nzTotal > 0

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

In order to hide the nz-pagination, one more condition is not taken into account: when nzTotal > 0

Issue Number: N/A

What is the new behavior?

now nz-pagination will be displayed when nzTotal > 0

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Jul 4, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (9dd14ae) to head (465ed90).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8628   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files         534      534           
  Lines       18425    18425           
  Branches     2905     2905           
=======================================
  Hits        16860    16860           
  Misses       1244     1244           
  Partials      321      321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants