Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize the transitions matrix to zero #1231

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Jul 23, 2024

Description:

Fixes #1230

Collaborators:

@slevis-lmwg via ESCOMP/CTSM#2656

Expectation of Answer Changes:

Yes, for satellite phenology cases run with the gnu compiler on derecho. However, the current test list with this combination is only in aux_clm

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results: TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Copy link
Contributor

@ckoven ckoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry I missed this and thanks @glemieux!

@glemieux
Copy link
Contributor Author

Regression testing in progress on derecho.

@glemieux
Copy link
Contributor Author

Regression testing on derecho is showing b4b results against fates-sci.1.77.1_api.36.0.0-ctsm5.2.015

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1231

@glemieux glemieux merged commit e372f0b into NGEET:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

landuse_transition_matrix is uninitialized for non-land use run modes
2 participants