Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and standardize per-ageclass history #1252

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Add comment about reproductive mass being 0.

2242bd1
Select commit
Loading
Failed to load commit list.
Open

Refactor and standardize per-ageclass history #1252

Add comment about reproductive mass being 0.
2242bd1
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-11-18 17:35:04 ago

5 / 8 tasks completed

3 tasks still to be completed

Details

Required Tasks

Task Status
FATES_VEGC_APPF was incorrectly not being updated for new cohorts (contributes to #1261). Incomplete
FATES_MORTALITY_CANOPY_SZAP and FATES_MORTALITY_USTORY_SZAP were incorrectly excluding termination and logging mortality. Incomplete
FATES_GPP_AP Incomplete
FATES_LAI_AP Incomplete
FATES_NCL_AP Incomplete
FATES_NPP_AP Incomplete
FATES_SCORCH_HEIGHT_APPF Incomplete
FATES_LBLAYER_COND_AP Incomplete
FATES_STOMATAL_COND_AP Incomplete
FATES_MORTALITY_CANOPY_SZAP (logging and termination mortality now included) Incomplete
FATES_MORTALITY_USTORY_SZAP (logging and termination mortality now included) Incomplete
FATES_VEGC_APPF (see #1261) Incomplete
FATES_BURNFRAC_AP Incomplete
FATES_DDBH_CANOPY_SZAP Incomplete
FATES_DDBH_USTORY_SZAP Incomplete
FATES_FIRE_INTENSITY_BURNFRAC_AP Incomplete
FATES_FUEL_AMOUNT_AP Incomplete
FATES_FUEL_AMOUNT_APFC Incomplete
FATES_MORTALITY_CFLUX_CANOPY Incomplete
FATES_MORTALITY_CFLUX_PF Incomplete
FATES_MORTALITY_CFLUX_USTORY Incomplete
FATES_NPLANT_CANOPY_SZAP Incomplete
FATES_NPLANT_SZAP Incomplete
FATES_NPLANT_SZAPPF Incomplete
FATES_NPLANT_USTORY_SZAP Incomplete
FATES_NPP_APPF Incomplete
FATES_SCORCH_HEIGHT_PF Incomplete
FATES_VEGC_AP Incomplete
The in-code documentation has been updated with descriptive comments Completed
The documentation has been assessed to determine if updates are necessary: Yes Completed
FATES PASS/FAIL regression tests were run Incomplete
Evaluation of test results for answer changes was performed and results provided Incomplete
Technical Note update: Incomplete
User's Guide update: Incomplete
Rename and add comments to update_history_dyn1() and update_history_dyn2() to indicate they're intended for site-level vs. multiplexed outputs, respectively. Completed
Move hio_ncl_si line back to update_history_dyn2() Completed
Add comment that this should be zero Completed
Fix this. Incomplete