Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arguments, improve output processing, keep time attributes #25

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Add arguments, improve output processing, keep time attributes #25

wants to merge 19 commits into from

Conversation

samsrabin
Copy link

@samsrabin samsrabin commented Sep 10, 2024 •
edited
Loading

Depends on merges of #23 and #24. Will rebase once those are in.

Bugfix: Somehow regridder can affect its input! This was manifesting as ds_to_regrid["time"] losing its attributes. I fixed this (238aff7) by ensuring that it always receives a copy. If you'd like, I can make a separate PR for this, or I can move it into #23 (which otherwise will conflict). (Also, this should probably be reported as a bug to xesmf.) Note that this does NOT affect the values actually written.

Argument improvements:

@samsrabin
_RegridTargetPrep(): Handle existing lon/lat dims/variables.
ea27ce3
@samsrabin
Rename coordinates too, not just dimensions.
d513a0e
@samsrabin
Don't rename coordinate variables in luh2.py main().
96df37e
@samsrabin
Loop through all vars in RegridLoop().
8c8c842 
Resolves NGEET#15: RegridLoop does not iterate to the last index in the LUH2 dataset variable list
@samsrabin
Simplify RegridLoop() with enumerate().
8d89551
@samsrabin
Reduce indentation in RegridLoop().
4acc984
@samsrabin
Further reduce indentation in RegridLoop().
9627cf5
@samsrabin
first_var now True for first variable.
ae13ecd
@samsrabin
Simplify messaging in RegridLoop().
b8cec4d
@samsrabin
Merge branch 'work-with-region-surfdata-2' into merged-20240910
308d8a1
@samsrabin
_main.py: Add function for shared arguments.
7c7314e
@samsrabin
Fix 'Gaurd' typo.
b318546
@samsrabin
Add -t/--test option.
ad07e18 
Regrids only one variable.
@samsrabin
Require --overwrite to overwrite existing output.
850c7b8 
Resolves NGEET#16.
@samsrabin
Make output parent directory, if needed.
af292e7 
Resolves NGEET#17.
@samsrabin
Check for write access.
e41898e 
Resolves NGEET#18.
@samsrabin samsrabin changed the title Add argument and improve arg processing Add arguments and improve arg processing Sep 10, 2024
@samsrabin samsrabin marked this pull request as draft September 11, 2024 13:41
@samsrabin
regrid.py: Always pass a copy to regridder.
238aff7 
Somehow regridder can affect its input! This was manifesting as ds_to_regrid["time"] losing its attributes.
@samsrabin samsrabin changed the title Add arguments and improve arg processing BUGFIX, + add arguments and improve arg processing Sep 11, 2024
@samsrabin samsrabin changed the title BUGFIX, + add arguments and improve arg processing Add arguments, improve output processing, keep time attributes Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for write permissions early Make output directory if needed Overwriting should not be on by default
1 participant
@samsrabin