Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda new toolchain #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Jan 14, 2019

This two commits are necessary to build netgen with conda-forge and the new-toolchain. this is a manually rebased version of #22. I will use this version for a new conda-build if it won't get merged into master.

There is some specific apple-stuff which is not necessary for osx-conda-builds. To reduce the number of patches add an option directly in the cmake.
@looooo looooo force-pushed the conda-new_toolchain branch 2 times, most recently from 813d1b9 to cbc5d6f Compare January 15, 2019 09:23
@looooo looooo force-pushed the conda-new_toolchain branch from cbc5d6f to 7f75302 Compare January 15, 2019 09:35
@@ -28,20 +28,22 @@ option( ENABLE_CPP_CORE_GUIDELINES_CHECK "Enable cpp core guideline checks on ng
option( USE_SPDLOG "Enable spd log logging" OFF)
option( DEBUG_LOG "Enable more debug output (may increase computation time) - only works with USE_SPDLOG=ON" OFF)
option( CHECK_RANGE "Check array range access, automatically enabled if built in debug mode" OFF)
option( BUILD_WITH_CONDA "set this to on if the library is compiled with conda-buid" OFF)
option( DYNAMIC_LINK_PYTHON "set this to OFF for static linking to python" ON)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the message here is maybe misleading. I guess it should be:
"set this to OFF to not link against python DSO"

@luzpaz
Copy link
Contributor

luzpaz commented May 28, 2019

bump

@luzpaz
Copy link
Contributor

luzpaz commented Jul 1, 2019

@mhochsteger
@JSchoeberl
Please respond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants