Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stubgen problems for some cases #4

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Fix stubgen problems for some cases #4

merged 5 commits into from
Jan 9, 2025

Conversation

johann-cm
Copy link
Contributor

This PR fixes two things:

  1. For some ngsolve addon projects, like NGSTrefftz, stubgen does not generate a folder of stub files, but rather just one stub file. This breaks the current install script, because it expects there to be a folder.
  2. If the install destination folder does not exist, the stub installation will fail quietly. This PR adds a check and an error message, if the install destination folder does not exist.

@mhochsteger mhochsteger merged commit 5de4134 into NGSolve:main Jan 9, 2025
@mhochsteger
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johann-cm @mhochsteger