Spell-check for PyreCodes / ShakerMaker+ CelerisTaichiEvent v0 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce) with curved harbor example case. Include Celeris WebGPU examples (Miami_Beach_FL and Ventura_Habor_CA) for later use
…subprocess install taichi at launch, TODO include a check for prior install first/add to nheri-simcenter pypi + add Taichi scripts to CMakeLists for building backend applications
…Pat/Willington specify appropriate license in their updated version)
…hecked contries --> countries in DatabaseMetadata.json, this may cause a bug or fix one)
|
@amnp95 @parduino I linted/formatted/spell-checked shaker-maker to get the green check-mark back on the repo. Shouldn't affect anything but I did change "contries" to "countries" in the database JSON file which may matter. I'm assuming it fixes a bug, but maybe not if shaker makers schema used the former spelling. If it looks like anything broke cause of this let me know |
JustinBonus
changed the title
|
that mispelling in Countries is also present in Backend when he parses the json for that key. will need to be fixed in both locations |
|
i fixed in SimCenterCommon and pulled justins in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Permission granted by Pat and Willington for reasonable redistribution related to the SimCenter's mission, all rights reserved. Event to be updated for full RV integration in the workflow, with a sensor/recorder scheme, and to a new version if Willington chooses to make it public.