Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge: NHS.UK Frontend v5 Changes #167

Merged
merged 15 commits into from
Dec 4, 2023
Merged

Merge: NHS.UK Frontend v5 Changes #167

merged 15 commits into from
Dec 4, 2023

Commits on Apr 12, 2023

  1. remove png from NHS Logo (#141)

    Co-authored-by: hrom1 <[email protected]>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    3 people authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    d04d1d4 View commit details
    Browse the repository at this point in the history
  2. Remove footer three column variant (#151)

    * Remove footer three column prop and test
    
    * Remove story with columns
    
    * Update branch with latest changes
    KaiSpencer authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    9c4c32d View commit details
    Browse the repository at this point in the history
  3. Remove TransactionalServiceName long variant (#152)

    * Remove TransactionalServiceName.tsx long variant
    
    * Update branch with latest changes
    KaiSpencer authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    2d72fb5 View commit details
    Browse the repository at this point in the history
  4. [nhsuk-frontend-v5] Move review date component into pattern (#138)

    * Move ReviewDate into patterns directory
    
    * Provide custom ordering to stories
    
    * Revert change to ReviewDate.test.tsx import
    
    * Adds migration docs for v3
    
    * Update branch with latest changes from target
    
    * Callout for v3 as wip release
    KaiSpencer authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    d685e90 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Add SVG Icon Attributes (#163)

    * Add SVG Icon fixes from NHSUK Frontend
    
    * Update snapshots
    Tomdango authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    37b6729 View commit details
    Browse the repository at this point in the history
  2. Add do not prefix to DoDontList (#153)

    * DoDontList don't item includes text `do not`, tests to cover
    
    * add prefixText prop and tests for DoDontList
    
    * Better documentation for DoDontList
    KaiSpencer authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f652811 View commit details
    Browse the repository at this point in the history
  3. Header Menu aria-expanded fix (#164)

    * Add dev warnings for v5 breaking changes (#150)
    
    * Add deprecation warning to footer columns prop
    
    * Shared warning object for v5
    
    * Dev warning for DoDontList.tsx
    
    * Dev warning for TransactionalServiceName.tsx
    
    * Dev warning for ReviewDate.tsx
    
    * Lint
    
    ---------
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Fix Readme CI Build status tag (#149)
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Only run CI on main and PR's (#148)
    
    Currently ci build will run on any push and any pull_request.
    Pushing to a feature branch kicks off CI unintentionally.
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Bump ansi-regex from 4.1.0 to 4.1.1 (#156)
    
    Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1.
    - [Release notes](https://github.com/chalk/ansi-regex/releases)
    - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1)
    
    ---
    updated-dependencies:
    - dependency-name: ansi-regex
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Bump minimatch from 3.0.4 to 3.1.2 (#155)
    
    Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
    - [Release notes](https://github.com/isaacs/minimatch/releases)
    - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
    - [Commits](isaacs/minimatch@v3.0.4...v3.1.2)
    
    ---
    updated-dependencies:
    - dependency-name: minimatch
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Update ErrorSummary component to forward refs (#135)
    
    This allows for things like programmatic keyboard focus in order to
    fulfil accessibility requirements.
    
    Co-authored-by: Phil Meier <[email protected]>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * bug/Checkbox declaration file inconsistency (#133)
    
    * Add "strictNullChecks", fix two cases where typing needs updating in line with checks.
    
    * Revert to .defaultProps
    
    * Throw error on default HeadingLevel.tsx case
    
    * Warn on invalid prop, test to cover
    
    * Better dev warning for heading level
    
    ---------
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Add aria-controls
    
    * Fix tests from main merge
    
    * Remove Dev Warnings
    
    * Final test cleanups
    
    * Remove unused import
    
    ---------
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: Kai Spencer <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Phil Meier <[email protected]>
    Co-authored-by: Phil Meier <[email protected]>
    5 people authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    c3cc350 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Add dev warnings for v5 breaking changes (#150)

    * Add deprecation warning to footer columns prop
    
    * Shared warning object for v5
    
    * Dev warning for DoDontList.tsx
    
    * Dev warning for TransactionalServiceName.tsx
    
    * Dev warning for ReviewDate.tsx
    
    * Lint
    
    ---------
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    KaiSpencer and Tomdango committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    caeb335 View commit details
    Browse the repository at this point in the history
  2. Header Menu aria-expanded fix (#164)

    * Add dev warnings for v5 breaking changes (#150)
    
    * Add deprecation warning to footer columns prop
    
    * Shared warning object for v5
    
    * Dev warning for DoDontList.tsx
    
    * Dev warning for TransactionalServiceName.tsx
    
    * Dev warning for ReviewDate.tsx
    
    * Lint
    
    ---------
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Fix Readme CI Build status tag (#149)
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Only run CI on main and PR's (#148)
    
    Currently ci build will run on any push and any pull_request.
    Pushing to a feature branch kicks off CI unintentionally.
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Bump ansi-regex from 4.1.0 to 4.1.1 (#156)
    
    Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1.
    - [Release notes](https://github.com/chalk/ansi-regex/releases)
    - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1)
    
    ---
    updated-dependencies:
    - dependency-name: ansi-regex
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Bump minimatch from 3.0.4 to 3.1.2 (#155)
    
    Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
    - [Release notes](https://github.com/isaacs/minimatch/releases)
    - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
    - [Commits](isaacs/minimatch@v3.0.4...v3.1.2)
    
    ---
    updated-dependencies:
    - dependency-name: minimatch
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Update ErrorSummary component to forward refs (#135)
    
    This allows for things like programmatic keyboard focus in order to
    fulfil accessibility requirements.
    
    Co-authored-by: Phil Meier <[email protected]>
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * bug/Checkbox declaration file inconsistency (#133)
    
    * Add "strictNullChecks", fix two cases where typing needs updating in line with checks.
    
    * Revert to .defaultProps
    
    * Throw error on default HeadingLevel.tsx case
    
    * Warn on invalid prop, test to cover
    
    * Better dev warning for heading level
    
    ---------
    
    Co-authored-by: Thomas Judd-Cooper <[email protected]>
    
    * Add aria-controls
    
    * Fix tests from main merge
    
    * Remove Dev Warnings
    
    * Final test cleanups
    
    * Remove unused import
    
    ---------
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: Kai Spencer <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Phil Meier <[email protected]>
    Co-authored-by: Phil Meier <[email protected]>
    5 people committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    b1ac87a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:NHSDigital/nhsuk-react-components i…

    …nto feature/nhsuk-frontend-v5
    Tomdango committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    017f6ba View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Add additional changelog

    Tomdango committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4fbfb04 View commit details
    Browse the repository at this point in the history
  2. Bump version

    Tomdango committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    ff51dbd View commit details
    Browse the repository at this point in the history
  3. Remove Dev Warning Tests

    Tomdango committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    abc95e2 View commit details
    Browse the repository at this point in the history
  4. Fix linting issues

    Tomdango committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9877403 View commit details
    Browse the repository at this point in the history
  5. Fix circular dependency

    Tomdango committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a6311cd View commit details
    Browse the repository at this point in the history