Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add width and height the NHS logo as per the core library #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrimesdev
Copy link
Member

@chrimesdev chrimesdev commented Jun 8, 2023

The NHS logo was missing a width and height attribute causing some validation issues.

There also seems to be a few extra attributes that might not be needed - but will leave for now. See the markup at: https://service-manual.nhs.uk/design-system/components/header

https://nhs-service-manual.slack.com/archives/CDJ29AQCD/p1686240007585369

The NHS logo was missing a width and height attribute causing some validation issues. 

https://nhs-service-manual.slack.com/archives/CDJ29AQCD/p1686240007585369
@chrimesdev chrimesdev closed this Jun 8, 2023
@chrimesdev chrimesdev reopened this Jun 8, 2023
Copy link
Contributor

@KaiSpencer KaiSpencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brill, thank you @chrimesdev

@sulyyk
Copy link

sulyyk commented Jun 12, 2023

Hi both - Developers on my team have gotten back to me with some additional validation issues with this. This is the message I've received from them:

it's showing for the logo too. The PR for the height and width hasn't been approved / pushed so maybe they could do both in the same fix.

This slack thread has a screenshot of the the validation errors being received

@chrimesdev
Copy link
Member Author

The <image> element on the SVG is no longer needed as support for IE browsers that required this for a fallback was dropped in the core frontend library - so this can be removed rather than adding a width and height to it.

@KaiSpencer
Copy link
Contributor

@Tomdango I don't have merging permissions, could you take a look and do the thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants