Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict peerDependency range for nhsuk-frontend to match supported version #179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Strict peerDependency range for nhsuk-frontend to match supported version #179

wants to merge 2 commits into from

Conversation

KaiSpencer
Copy link
Contributor

Fixes #178

Enforce any v4 of nhsuk-frontend

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Tomdango
Tomdango requested changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Tomdango Tomdango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updating to nhsuk-frontend>=5.0.0<6 now that v5 is live.

@KaiSpencer
Merge branch 'main' of personal:NHSDigital/nhsuk-react-components int…
ae84443 
…o tighten-nhsuk-frontend-peerDependency-range
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KaiSpencer KaiSpencer mentioned this pull request Jan 23, 2024
Closed
@birksy89
Copy link

birksy89 commented Feb 2, 2024

Sorry to bother, but we also ran into this @Tomdango

Would be grateful if this could be reviewed & merged 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomdango Tomdango Awaiting requested review from Tomdango

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lax peerDependency range causes bugs with later releases of nhsuk-frontend
3 participants
@KaiSpencer @birksy89 @Tomdango