Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow support for module directives in build process #199

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Allow support for module directives in build process #199

merged 1 commit into from
Mar 19, 2024

Conversation

JoshuaBates-NHS
Copy link
Collaborator

Includes:

  • ability to implement 'use client' module directives for 'client' components
  • preserved ESM component output
  • aligned TS output (from rollup instead of separate process)

@JoshuaBates-NHS JoshuaBates-NHS force-pushed the feature/nhsuk-frontend-v8_directive-support branch from 8417092 to e52d6c6 Compare March 19, 2024 12:01
allow support for module directives in build process. Added use clien…
4c7d0e2 
…t directives to client components

move types under esm to inline with raw components

fix preserveModulesRoot option to src
@JoshuaBates-NHS JoshuaBates-NHS force-pushed the feature/nhsuk-frontend-v8_directive-support branch from e52d6c6 to 4c7d0e2 Compare March 19, 2024 13:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jakeb-nhs jakeb-nhs self-requested a review March 19, 2024 14:00
@JoshuaBates-NHS JoshuaBates-NHS merged commit 03cc471 into feature/nhsuk-frontend-v8 Mar 19, 2024
2 checks passed
@JoshuaBates-NHS JoshuaBates-NHS deleted the feature/nhsuk-frontend-v8_directive-support branch March 19, 2024 14:06
@jakeb-nhs jakeb-nhs mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeb-nhs jakeb-nhs jakeb-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaBates-NHS @jakeb-nhs