Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new components since nhsuk-frontend v5 #202

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add new components since nhsuk-frontend v5 #202

merged 1 commit into from
Mar 22, 2024

Conversation

jakeb-nhs
Copy link
Collaborator

@jakeb-nhs jakeb-nhs commented Mar 19, 2024 •
edited
Loading

Added new components/features

  • 'None of these' feature to checkboxes
  • 'Primary' and 'secondary' card variants
  • Tabs component
  • Character count component

@jakeb-nhs jakeb-nhs force-pushed the feature/nhsuk-frontend-v8_new_components branch from 8780083 to fa5e148 Compare March 19, 2024 15:48
JoshuaBates-NHS
JoshuaBates-NHS requested changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@JoshuaBates-NHS JoshuaBates-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to look at

docs/upgrade-to-4.0.md Outdated Show resolved Hide resolved
src/components/content-presentation/tabs/__tests__/Tabs.test.tsx Show resolved Hide resolved
src/components/form-elements/character-count/CharacterCount.tsx Outdated Show resolved Hide resolved
src/components/content-presentation/tabs/Tabs.tsx Outdated Show resolved Hide resolved
src/components/form-elements/checkboxes/components/Divider.tsx Show resolved Hide resolved
src/components/navigation/card/components/CardContent.tsx Outdated Show resolved Hide resolved
@jakeb-nhs jakeb-nhs force-pushed the feature/nhsuk-frontend-v8_new_components branch 2 times, most recently from 277f87a to baaf8b8 Compare March 22, 2024 09:26
JoshuaBates-NHS
JoshuaBates-NHS reviewed Mar 22, 2024
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@jakeb-nhs jakeb-nhs force-pushed the feature/nhsuk-frontend-v8_new_components branch from baaf8b8 to 6664848 Compare March 22, 2024 10:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jakeb-nhs jakeb-nhs merged commit d2b7f4b into feature/nhsuk-frontend-v8 Mar 22, 2024
1 of 2 checks passed
@jakeb-nhs jakeb-nhs deleted the feature/nhsuk-frontend-v8_new_components branch March 22, 2024 11:37
@jakeb-nhs jakeb-nhs mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBates-NHS JoshuaBates-NHS JoshuaBates-NHS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakeb-nhs @JoshuaBates-NHS