Fixes/workaround for CJS consumption of components with nhsuk-frontend JS references. Better align components and stories to their folders/categories. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeb-nhs
force-pushed
the
feature/nhsuk-frontend-v8_cjs-fixes-and-component-moves
branch
from
dba03a3
to
9d5b65b
Compare
|
In storybook on the welcome page, could you add a link under the migration for migrating from 3.x to v4 (I think 1 is missing from 2.x to v3 too) - just a link through to the migration guides |
|
We can remove the 'Components' entry from |
JoshuaBates-NHS
requested changes
Apr 10, 2024
…d JS references. Better align components and stories to their folders/categories.
jakeb-nhs
force-pushed
the
feature/nhsuk-frontend-v8_cjs-fixes-and-component-moves
branch
from
9d5b65b
to
847195f
Compare
|
JoshuaBates-NHS
approved these changes
Apr 10, 2024
jakeb-nhs
deleted the
feature/nhsuk-frontend-v8_cjs-fixes-and-component-moves
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/workaround for CJS consumption of components with nhsuk-frontend JS references. Better align components and stories to their folders/categories.