Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate nhsuk-frontend v8, bringing components into line with the current style guide. #211

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
11 changes: 0 additions & 11 deletions .babelrc

This file was deleted.

4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
jest.config.js
.eslintrc.js
rollup.config.mjs
dist
41 changes: 0 additions & 41 deletions .eslintrc

This file was deleted.

41 changes: 41 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
module.exports = {
parserOptions: {
project: './tsconfig.json',
tsconfigRootDir: __dirname,
},
env: {
browser: true,
jest: true,
},
settings: {
'import/resolver': {
typescript: {},
},
react: {
version: 'detect',
},
},
extends: [
'plugin:react/recommended',
'plugin:@typescript-eslint/recommended',
'prettier',
'plugin:import/errors',
'plugin:import/warnings',
'plugin:import/typescript',
'plugin:jsx-a11y/recommended',
'plugin:react-hooks/recommended',
],
rules: {
'react/prop-types': 0,
'jsx-a11y/anchor-has-content': 0,
'jsx-a11y/alt-text': 0,
'jsx-a11y/heading-has-content': 0,
'react-hooks/exhaustive-deps': 0,
},
overrides: [
{
files: ['*.stories.tsx'],
rules: { '@typescript-eslint/no-unused-vars': 'off' },
},
],
};
14 changes: 11 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
name: CI Build

on:
on:
push:
branches: main
pull_request:
pull_request:

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: '18.x'
- name: Enable corepack
run: corepack enable
- name: Set Yarn version
run: yarn set version stable
- name: Yarn Install
run: yarn
- name: Lint
Expand Down
33 changes: 23 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,39 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1

- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: '18.x'

- name: Enable corepack
run: corepack enable

- name: Set Yarn version
run: yarn set version stable

- name: Yarn Install
run: yarn

- name: Lint
run: yarn lint
run: yarn lint:ci

- name: Jest Tests
run: yarn test:ci

- name: Typescript build
run: yarn build

- name: Set Version to Release Tag Name
run: |
yarn version --new-version ${{ github.event.release.tag_name }} --no-git-tag-version
yarn version ${{ github.event.release.tag_name }}

- name: Publish to npm, publish pre-release as beta
uses: JS-DevTools/npm-publish@v1
uses: JS-DevTools/npm-publish@v1
with:
token: ${{ secrets.NPM_TOKEN }}
tag: ${{ github.event.release.prerelease && 'beta' || 'latest' }}
17 changes: 14 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*

# Diagnostic reports (https://nodejs.org/api/report.html)
Expand Down Expand Up @@ -65,6 +63,18 @@ typings/
# Output of 'npm pack'
*.tgz

# Yarn files
yarn-error.log
yarn-debug.log*
yarn-error.log*
.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

# Yarn Integrity file
.yarn-integrity

Expand Down Expand Up @@ -108,8 +118,9 @@ dist

# Custom
lib/
yarn-error.log
storybook-static/

# IDEA files
.idea/

.DS_Store
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18
11 changes: 11 additions & 0 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import type { StorybookConfig } from '@storybook/react-vite';
import { mergeConfig } from 'vite';
import tsConfigPaths from 'vite-tsconfig-paths';

const config: StorybookConfig = {
stories: ['../stories/**/*.stories.@(ts|tsx)', '../stories/**/*.mdx'],
addons: ['@storybook/addon-links', '@storybook/addon-essentials'],
Expand All @@ -9,5 +12,13 @@ const config: StorybookConfig = {
docs: {
autodocs: true,
},
typescript: {
reactDocgen: 'react-docgen-typescript',
},
viteFinal(config) {
return mergeConfig(config, {
plugins: [tsConfigPaths()],
});
},
};
export default config;
2 changes: 1 addition & 1 deletion .storybook/manager.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { addons } from '@storybook/addons';
import { addons } from '@storybook/manager-api';
import nhsTheme from './theme';

addons.setConfig({
Expand Down
9 changes: 9 additions & 0 deletions .storybook/preview-head.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<script type="text/javascript">
document.addEventListener(
'DOMContentLoaded',
function () {
document.body.classList.add('js-enabled');
},
false,
);
</script>
10 changes: 9 additions & 1 deletion .storybook/preview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,15 @@ const preview: Preview = {
actions: { argTypesRegex: '^on[A-Z].*' },
options: {
storySort: {
order: ['Welcome', 'Migration Guides', 'Components', 'Patterns', 'FormBehaviour', 'Deprecated'],
order: [
'Welcome',
'Migration Guides',
'Form Elements',
'Content Presentation',
'Navigation',
'Layout',
'Patterns',
],
},
},
},
Expand Down
5 changes: 0 additions & 5 deletions .storybook/storybook.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
// Also import styles for deprecated Panel and Promo
@import '../node_modules/nhsuk-frontend-legacy/packages/core/all.scss';
@import '../node_modules/nhsuk-frontend-legacy/packages/components/panel/panel';
@import '../node_modules/nhsuk-frontend-legacy/packages/components/promo/promo';

// Allow current nhsuk styles to override legacy
@import '../node_modules/nhsuk-frontend/packages/nhsuk.scss';

Expand Down
20 changes: 20 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Launch Program",
"skipFiles": [
"<node_internals>/**"
],
"program": "${workspaceFolder}/dist/index.js",
"outFiles": [
"${workspaceFolder}/**/*.js"
]
}
]
}
16 changes: 16 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"editor.defaultFormatter": "esbenp.prettier-vscode",
"eslint.format.enable": true,
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll": "explicit",
"source.fixAll.eslint": "explicit"
},
"eslint.validate": ["javascript", "typescript"],
"eslint.codeAction.showDocumentation": {
"enable": true
},
"eslint.alwaysShowStatus": true,
"eslint.workingDirectories": ["src"],
"typescript.tsdk": "node_modules/typescript/lib"
}
2 changes: 2 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
nodeLinker: node-modules
npmRegistryServer: https://registry.yarnpkg.com
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2020 NHS Digital
Copyright (c) 2024 NHS England

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
- [NHS.UK React Components](#nhsuk-react-components)
- [Coming from 0.x?](#coming-from-0x)
- [Upgrading to 2.0](#upgrading-to-20)
- [Upgrading to 3.0](#upgrading-to-30)
- [Upgrading to 4.0](#upgrading-to-40)
- [Installation](#installation)
- [Usage](#usage)
- [Storybook](#storybook)
Expand All @@ -21,6 +23,14 @@ If you're coming from versions of the library prior to 1.0.0, please give [this

If you're upgrading to 2.0, please be aware we have made some breaking changes. [This doc](/docs/upgrade-to-2.0.md) has the details.

## Upgrading to 3.0

If you're upgrading to 3.0, please be aware we have made some breaking changes. [This doc](/docs/upgrade-to-3.0.md) has the details.

## Upgrading to 4.0

If you're upgrading to 4.0, please be aware we have made some breaking changes. [This doc](/docs/upgrade-to-4.0.md) has the details.

## Installation

You can install this package using either `yarn` or `npm`.
Expand Down
32 changes: 32 additions & 0 deletions bundle-base.tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"compilerOptions": {
"jsx": "react",
"target": "es6",
"module": "esnext",
"moduleResolution": "node",
"baseUrl": "./",
"types": ["jest", "node"],
"sourceMap": true,
"forceConsistentCasingInFileNames": true,
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"skipLibCheck": true,
"strict": true,
"strictNullChecks": true,
"resolveJsonModule": true,
"allowJs": true,
"outDir": "./dist",
"paths": {
"@components/*": ["src/components/*"],
"@content-presentation/*": ["src/components/content-presentation/*"],
"@form-elements/*": ["src/components/form-elements/*"],
"@navigation/*": ["src/components/navigation/*"],
"@typography/*": ["src/components/typography/*"],
"@util/*": ["src/util/*"],
"@patterns/*": ["src/patterns/*"],
"@resources/*": ["src/resources/*"]
}
},
"include": ["src"],
"exclude": ["node_modules", "**/__tests__", "src/setupTests.ts"]
}
Loading
Loading