Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with SkipLink and align to NHSUK frontend #248

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix issues with SkipLink and align to NHSUK frontend #248

merged 1 commit into from
Sep 3, 2024

Conversation

jakeb-nhs
Copy link
Collaborator

  • Always set href on the SkipLink element so that users without JS enabled can still use it
    • Because the link callsevent.preventDefault() when disableDefaultBehaviour is true, the behaviour is still prevented without needing to remove the href
  • Introduce new prop for controlling the heading focus functionality separate to the event.preventDefault behaviour

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jakeb-nhs jakeb-nhs added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 80edae3 Sep 3, 2024
2 checks passed
@jakeb-nhs jakeb-nhs deleted the align-skiplink-behaviour branch September 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBates-NHS JoshuaBates-NHS JoshuaBates-NHS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakeb-nhs @JoshuaBates-NHS